Change type of defualts for include_deferred #33271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should change the defaults to client defaults for MSSQL compatibility The change in apache#32709 was not liked by MSSQL
ephraimbuddy
approved these changes
Aug 9, 2023
hussein-awala
approved these changes
Aug 9, 2023
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
added a commit
that referenced
this pull request
Aug 9, 2023
We should change the defaults to client defaults for MSSQL compatibility The change in #32709 was not liked by MSSQL Co-authored-by: Ephraim Anierobi <[email protected]> (cherry picked from commit d989e9d)
Member
|
Gosh no, this is exactly the thing I rejected in the original PR. Please don't. |
Member
Author
|
Sure - if we know how to handle it better so that all our dbs are happy with it + offline migrations - I am super happy about server defaults. My change was based on the observation that so far none of our migrations did it. But agree that would be more consistent if we can solve all the "multi-db/sqlalchemy woes connected with it). Or drop MSSQL which I advocated on the devlist about 3 times already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should change the defaults to client defaults for MSSQL compatibility The change in #32709 was not liked by MSSQL
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.