Fix venv detection for Python virtualenv operator#33223
Merged
Conversation
jedcunningham
left a comment
jedcunningham
left a comment
Member
There was a problem hiding this comment.
Can you also update example dags tutorial_taskflow_api_virtualenv.py and example_python_operator.py.
This is a follow-up after apache#32939. It seems that findspec does not cover all the cases and the previous check is also faster. Adding check for the binary first and then falling back to spec finding will make it faster and work in the cases where the findspec does not work (for local development cases).
potiuk
force-pushed
the
fix-venv-detection
branch
from
August 8, 2023 22:33
4ab52aa to
4f448c4
Compare
Member
Author
Ah ... now I understand why you insisted on extracting it :) Done. |
jedcunningham
approved these changes
Aug 8, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 9, 2023
This is a follow-up after #32939. It seems that findspec does not cover all the cases and the previous check is also faster. Adding check for the binary first and then falling back to spec finding will make it faster and work in the cases where the findspec does not work (for local development cases). (cherry picked from commit c4fe5b8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up after #32939. It seems that findspec does not cover all the cases and the previous check is also faster.
Adding check for the binary first and then falling back to spec finding will make it faster and work in the cases where the findspec does not work (for local development cases).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.