Move openlineage configuration to provider#33124
Merged
hussein-awala merged 1 commit intoAug 4, 2023
Merged
Conversation
boring-cyborg
Bot
added
area:providers
kind:documentation
provider:openlineage
eladkal
approved these changes
Aug 4, 2023
potiuk
force-pushed
the
move-configuration-for-openlineage-to-provider
branch
from
August 4, 2023 17:59
315a656 to
c3ab246
Compare
Member
Author
|
mobuchowski
approved these changes
Aug 4, 2023
potiuk
force-pushed
the
move-configuration-for-openlineage-to-provider
branch
from
August 4, 2023 18:24
c3ab246 to
e03cc59
Compare
potiuk
commented
Aug 4, 2023
Member
Author
There was a problem hiding this comment.
@mobuchowski - I had to add explicit fallback here as our "import" check checks the case where the providers are imported directly - and Provider's Manager might not yet have been initialized with provider configurations. So all top-level imports of configuration have to have explicit fallback, despite it being also specified in the provider.yaml
Contributor
There was a problem hiding this comment.
OK - makes sense. Top level means here "before initialization of plugins", right?
Member
Author
There was a problem hiding this comment.
Had to also add it for others.
hussein-awala
approved these changes
Aug 4, 2023
potiuk
force-pushed
the
move-configuration-for-openlineage-to-provider
branch
2 times, most recently
from
August 4, 2023 19:04
dad4c93 to
51798ea
Compare
potiuk
force-pushed
the
move-configuration-for-openlineage-to-provider
branch
from
August 4, 2023 19:24
51798ea to
f074a98
Compare
44 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 8, 2023
(cherry picked from commit bdc10a5)
ephraimbuddy
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.