Skip to content

Allows to choose SSL context for IMAP provider#33108

Merged
potiuk merged 3 commits into
apache:mainfrom
potiuk:add-imap-provider-ssl-context-option
Aug 4, 2023
Merged

Allows to choose SSL context for IMAP provider#33108
potiuk merged 3 commits into
apache:mainfrom
potiuk:add-imap-provider-ssl-context-option

Conversation

@potiuk

@potiuk potiuk commented Aug 4, 2023

Copy link
Copy Markdown
Member

This change add two options to choose from when SSL IMAP connection is created:

  • default - for balance between compatibility and security
  • none - in case compatibility with existing infrastructure is preferred

The fallback is:

  • The Airflow "email", "ssl_context"
  • "default"

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This change add two options to choose from when SSL IMAP connection is created:

* default - for balance between compatibility and security
* none - in case compatibility with existing infrastructure is preferred

The fallback is:

* The Airflow "email", "ssl_context"
* "default"
@potiuk
potiuk force-pushed the add-imap-provider-ssl-context-option branch from 2e8f658 to b20d631 Compare August 4, 2023 10:31
@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Aug 4, 2023
@potiuk potiuk closed this Aug 4, 2023
@potiuk potiuk reopened this Aug 4, 2023
Comment thread airflow/providers/imap/CHANGELOG.rst Outdated
Comment thread airflow/providers/imap/CHANGELOG.rst Outdated
Comment thread airflow/providers/imap/hooks/imap.py
@potiuk

potiuk commented Aug 4, 2023

Copy link
Copy Markdown
Member Author

All good. Random failures /flaky tests only.

@potiuk
potiuk merged commit 52ca7bf into apache:main Aug 4, 2023
@potiuk
potiuk deleted the add-imap-provider-ssl-context-option branch August 4, 2023 12:28
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 4, 2023
The previous changes apache#33070 and apache#33108 added configuration parameters
to allow "ssl_context" to be configured "per installation of airflow".

The ssl_context extras allow to override the system-wide setting with
extras configured per-connection.
eladkal pushed a commit that referenced this pull request Aug 4, 2023
…ons (#33112)

The previous changes #33070 and #33108 added configuration parameters
to allow "ssl_context" to be configured "per installation of airflow".

The ssl_context extras allow to override the system-wide setting with
extras configured per-connection.
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 8, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.0 milestone Aug 8, 2023
ephraimbuddy added a commit that referenced this pull request Aug 8, 2023
* Allows to choose SSL context for IMAP provider

This change add two options to choose from when SSL IMAP connection is created:

* default - for balance between compatibility and security
* none - in case compatibility with existing infrastructure is preferred

The fallback is:

* The Airflow "email", "ssl_context"
* "default"

Co-authored-by: Ephraim Anierobi <[email protected]>
(cherry picked from commit 52ca7bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:imap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants