Fix issue with using the various state enum value in logs#33065
Merged
Conversation
The secrets masker is unable to work on the various state enums: DagRunState, TaskInstanceState, JobState, and State enums in logs. This PR fixes this by converting the enums to strings during the secrets mask search
pankajkoti
reviewed
Aug 3, 2023
hussein-awala
approved these changes
Aug 3, 2023
2 tasks
ephraimbuddy
added a commit
that referenced
this pull request
Aug 3, 2023
* Fix issue with using the various state enum value in logs The secrets masker is unable to work on the various state enums: DagRunState, TaskInstanceState, JobState, and State enums in logs. This PR fixes this by converting the enums to strings during the secrets mask search * fixup! Fix issue with using the various state enum value in logs * apply to all enum * test with custom enum (cherry picked from commit b0f61be)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secrets masker is unable to work on the various state enums: DagRunState, TaskInstanceState, JobState, and State enums in logs.
This PR fixes this by converting the enums to strings during the secrets mask search
closes: #33061