Fix BaseOperator get_task_instances query#33054
Merged
Merged
Conversation
amoghrajesh
reviewed
Aug 3, 2023
Member
Author
|
@potiuk @amoghrajesh could you take a second look? |
potiuk
approved these changes
Aug 3, 2023
Member
|
LGTM |
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Fix BaseOperator get_task_instances query * add unit test (cherry picked from commit f5a83bc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the query of
BaseOperator.get_task_instancesmethod which accept None start and end dates, where when we provide a None start_date (the default value), we get the following exception:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.