Get rid of Python2 numeric relics#33050
Merged
Merged
Conversation
eumiro
requested review from
XD-DENG,
ashb,
bbovenzi,
eladkal,
jedcunningham,
kaxil,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
August 2, 2023 20:06
boring-cyborg
Bot
added
area:dev-tools
area:providers
area:webserver
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
uranusjr
reviewed
Aug 3, 2023
Member
There was a problem hiding this comment.
I wonder why the outer floor existed in the first place. That wouldn’t do anything on Python 2 either…
uranusjr
reviewed
Aug 3, 2023
uranusjr
approved these changes
Aug 3, 2023
potiuk
approved these changes
Aug 3, 2023
pierrejeambrun
approved these changes
Aug 3, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 4, 2023
(cherry picked from commit e3d82c6)
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from Python2 to Python3 changes some numeric behavior. In Python3:
round(),math.ceil()andmath.floor()returnintinstead offloatint / intreturnsfloatand therefore it is not necessary to convert one of the parts tofloator to multiply the expression by1.0The code has been simplified. No functionality has been changed.