Remove old graph#32958
Conversation
eladkal
left a comment
There was a problem hiding this comment.
LGTM but better to also be reviewed by @pierrejeambrun
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good, glad to see this one removed in favor of our new modern graph details! 🎉
(cherry picked from commit 154deed)
I suggest you look at latest version and if you have proposals how to improve, open an issue describing it. Or better. PR improving it. |
|
Ideally with screenshots before, after (latest version) and clearly marking what exactly the problem you want to solve. |
|
I think I asked you to open a new issue with those suggestions. It makes no sense to add comments to closed and merged PR. Those are interesting comments and adding them as suggestions for improvement (ideally each suggestion separately) is the only way it wil become actionable. |
|
@potiuk The only thing I can't figure out with this new view is how to go to the "graph" view from a link to the task logs. The redirection doesn't work when the dag run you're trying to view in a graph is outside the default selected number of dag runs. Link to task logs. Note how the "graph" button goes to
Since this particular dag run was like 200 or so dag_runs in the past, once redirected the graph shows without a selected run. I can only go there by manually adding Is there a way around this? Having that old link also specify the Maybe I'm missing something obvious. |
|
This is also true when clicking on dag_run from the list dag_run tables. Created an issue. |




Remove the old graph view and redirect all requests to the new graph in the grid view.
Part of #29852
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.