Clean-up of our new security page#32951
Merged
Merged
Conversation
Member
Author
|
Compare the current page:
With the new one:
|
The new security page of ours looked a bit messy - mixing the security model, information about security patches and index of "all other" security topics. This change cleans it up quite a bit: * "Airflow Security Model" and "Releasing security patches" are separated out - each to a separate page focusing only on model/release respectively * The index now does not contain everything mixed together - both in navigation and main page index * The model and releasing are also explicitly called out in the intro paragraphs for the securtiy index, underlying their importance - explaining to the reader that they should look at them first to understand the important topics mentioned in them.
potiuk
force-pushed
the
cleanup-security-page
branch
from
July 30, 2023 16:32
0d04b88 to
5972383
Compare
Member
|
Overall looks good. Feel free to take or leave all of these suggestions. |
Co-authored-by: Jed Cunningham <[email protected]>
Member
Author
I'll take 'em |
Member
Author
|
All things addressed @jedcunningham. |
jedcunningham
approved these changes
Aug 1, 2023
| clearing, re-running, triggering DAGs, and changing parameters. | ||
| Depending on access restrictions, they may also have access to | ||
| editing variables and viewing Airflow configuration. They should not | ||
| have access to sensitive system-level information or connections, and |
Member
There was a problem hiding this comment.
I'll start a separate PR for my suggestions here 👍
Member
Author
|
cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new security page of ours looked a bit messy - mixing the security model, information about security patches and index of "all other" security topics.
This change cleans it up quite a bit:
"Airflow Security Model" and "Releasing security patches" are separated out - each to a separate page focusing only on model/release respectively
The index now does not contain everything mixed together - both in navigation and main page index
The model and releasing are also explicitly called out in the intro paragraphs for the securtiy index, underlying their importance - explaining to the reader that they should look at them first to understand the important topics mentioned in them.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.