Skip to content

Unwrap Proxy before checking __iter__ in is_container()#32850

Merged
eladkal merged 4 commits into
apache:mainfrom
gecko655:fix-is-container
Jul 28, 2023
Merged

Unwrap Proxy before checking __iter__ in is_container()#32850
eladkal merged 4 commits into
apache:mainfrom
gecko655:fix-is-container

Conversation

@gecko655

Copy link
Copy Markdown
Contributor

Preventing lazy_object_proxy.Proxy, like Proxy(lambda : 1), from being determined to be a container by is_container().

Fixes: #32804

@boring-cyborg

boring-cyborg Bot commented Jul 26, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Comment thread airflow/utils/helpers.py Outdated
Co-authored-by: YAMAMORI, Akihiro <[email protected]>
@gecko655

Copy link
Copy Markdown
Contributor Author

𝙉𝙚𝙫𝙚𝙧 𝙚𝙣𝙙𝙞𝙣𝙜 𝙂𝙞𝙩𝙃𝙪𝙗 𝙖𝙘𝙩𝙞𝙤𝙣

@eladkal eladkal added this to the Airflow 2.6.4 milestone Jul 28, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jul 28, 2023
@eladkal
eladkal merged commit 12228d1 into apache:main Jul 28, 2023
@boring-cyborg

boring-cyborg Bot commented Jul 28, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DagRun.find() fails when given execution_date obtained from context.get('execution_date') directly

3 participants