Skip to content

Add example for list-import-errors as a CI check#32811

Merged
uranusjr merged 4 commits into
apache:mainfrom
fjmacagno:patch-1
Aug 7, 2023
Merged

Add example for list-import-errors as a CI check#32811
uranusjr merged 4 commits into
apache:mainfrom
fjmacagno:patch-1

Conversation

@fjmacagno

Copy link
Copy Markdown
Contributor

As a followup to #31655, adds an example for using the CLI list-import-errors command to test for import errors as part of a CI job, including a note about how to avoid unexpected logging that can interfere with the test.

related: #31655

@boring-cyborg

boring-cyborg Bot commented Jul 24, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Comment thread docs/apache-airflow/howto/usage-cli.rst Outdated
@uranusjr

Copy link
Copy Markdown
Member

This file is restructuredText, not Markdown, you need to fix the syntax.

@fjmacagno

Copy link
Copy Markdown
Contributor Author

My apologies, just started writing on autopilot. I think it is fixed now.

Comment thread docs/apache-airflow/howto/usage-cli.rst Outdated
Comment thread docs/apache-airflow/howto/usage-cli.rst Outdated
Comment thread docs/apache-airflow/howto/usage-cli.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: For this to work accurately, you must ensure Airflow does not log any additional text to stdout. For example, you may need to fix any deprecation warnings, or you may need to set `lazy_load_plugins = True` in the Airflow config if you have a plugin that logs when loaded.
.. note::
For this to work accurately, you must ensure Airflow does not log any additional text to stdout. For example, you may need to fix any deprecation warnings, or need to set ``lazy_load_plugins = True`` in the Airflow config if you have a plugin that logs when loaded.

I think deprecation warnings log to stderr and can be avoided with 2>/dev/null though?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite possible, i fixed my deprecation warnings so i don't have an easy way to test, but i can include that as a recommendation.

@uranusjr

Copy link
Copy Markdown
Member

Need to fix CI failures in static checks and doc build.

@eladkal eladkal added this to the Airflow 2.7.1 milestone Aug 6, 2023
@eladkal eladkal added the type:doc-only Changelog: Doc Only label Aug 6, 2023
@uranusjr
uranusjr merged commit 1b2b666 into apache:main Aug 7, 2023
@boring-cyborg

boring-cyborg Bot commented Aug 7, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@fjmacagno
fjmacagno deleted the patch-1 branch August 7, 2023 16:58
ephraimbuddy pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants