Refactor existence-checking SQL to helper#32790
Merged
Merged
Conversation
I'm guessing this should be common enough to warrant a helper function. Some are identified and changed in this PR; I'm pretty sure there are more, but we can change them once by once when found.
Lee-W
approved these changes
Jul 24, 2023
jedcunningham
approved these changes
Jul 25, 2023
| return session.scalar(count_stmt) | ||
|
|
||
|
|
||
| def exists_query(*where: ClauseElement, session: Session) -> bool: |
Member
There was a problem hiding this comment.
Suggested change
| def exists_query(*where: ClauseElement, session: Session) -> bool: | |
| def exists_query(*where: ClauseElement, *, session: Session) -> bool: |
Member
Author
There was a problem hiding this comment.
Can’t do this because where is already a star args. Bare * is (syntactically) a special case of *name and you can only have one star argument in the argument list.
dstandish
approved these changes
Jul 25, 2023
ephraimbuddy
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing this should be common enough to warrant a helper function. Some are identified and changed in this PR; I'm pretty sure there are more, but we can change them once by once when found.