Add support for arrays of different data types in the Trigger Form UI#32734
Merged
eladkal merged 7 commits intoAug 3, 2023
Merged
Conversation
MatthieuBlais
requested review from
ashb,
bbovenzi,
pierrejeambrun,
potiuk and
ryanahamilton
as code owners
July 21, 2023 02:26
jscheffl
approved these changes
Jul 22, 2023
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Just some small beautification proposals in documentation, otherwise - I like it! Thanks for the contribution!
(Take my approval emotional, I have no committer status)
MatthieuBlais
force-pushed
the
feature/complex_arrays_for_trigger_forms
branch
from
July 23, 2023 15:00
9ed9cf4 to
f029ad1
Compare
Contributor
Author
|
Great, thanks for the feedback! I've updated the PR with your commits |
Contributor
Uuups, sorry, my comments were not syntax checked :-( The URL is not correctly formed to be accepted by Sphinx. |
Co-authored-by: Jens Scheffler <[email protected]>
Co-authored-by: Jens Scheffler <[email protected]>
MatthieuBlais
force-pushed
the
feature/complex_arrays_for_trigger_forms
branch
from
July 24, 2023 15:00
496b0a1 to
808d2bb
Compare
jscheffl
approved these changes
Jul 24, 2023
eladkal
approved these changes
Aug 3, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 3, 2023
…#32734) * Add JSON field for complex arrays with types other than string --------- Co-authored-by: Matthieu Blais <[email protected]> Co-authored-by: Jens Scheffler <[email protected]> Co-authored-by: eladkal <[email protected]> (cherry picked from commit da69315)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new Trigger Form UI released in 2.6 is handy but doesn't support
arrayparams of data types other than string. For more flexibility, this PR proposes to generate a JSON field similar to theobjectparam if the users specify the attributeitemsinschema.How to reproduce the issue
Use an
arrayparam and require the items to be integers.The Generated Conf JSON shows an array of strings
And we cannot trigger the DAG:
Workaround
We can manually update the Generated Configuration JSON box, but it is not user friendly (especially if we expect an array of objects!), and will become counter intuitive as users get used to the benefits of the new trigger form.
What do you think @jens-scheffler-bosch ?