Add explicit browsers list and correct rel for blank target links#32633
Merged
pierrejeambrun merged 1 commit intoJul 16, 2023
Merged
Conversation
pierrejeambrun
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
July 16, 2023 10:24
boring-cyborg
Bot
added
area:UI
pierrejeambrun
changed the title
potiuk
approved these changes
Jul 16, 2023
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Not sure if the defaults are right for browserslist, but they look good.
hussein-awala
approved these changes
Jul 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
noopenerandnoreferrerto alltarget="_blank"link.Also add the browserslist query in our
package.json. Use the same as create-react-app that sets a standard.support is a little bit wider than the defaults query.