Fix returned value when ShortCircuitOperator condition is falsy and there is not downstream tasks#32623
Merged
Merged
Conversation
…here is not downstream tasks
eladkal
approved these changes
Jul 15, 2023
potiuk
approved these changes
Jul 15, 2023
Member
|
It's pass the tests that failed in main. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #32569
related: #32538
#32569 has fixed a bug in the ShortCircuitOperator by returning the falsy result as it, to create the xcom, however, in the same time #32538 has fixed another bug by adding a fast return
Nonewhen there is not downstream tasks. This PR replaces the returnNoneby returning the falsy result as it is to handle the two bugs.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.