Use isdisjoint instead of not intersection#32616
Merged
Merged
Conversation
dstandish
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
July 14, 2023 19:16
dstandish
commented
Jul 14, 2023
| return False | ||
|
|
||
| if not user_roles.intersection(set(self.roles)): | ||
| if user_roles.isdisjoint(self.roles): |
Contributor
Author
There was a problem hiding this comment.
note on removal of set: roles doesn't need to be set to pass to isdisjoint
uranusjr
approved these changes
Jul 14, 2023
hussein-awala
approved these changes
Jul 15, 2023
Member
|
Nice. Indeed faster as it can short-circuit when match is found |
potiuk
approved these changes
Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's faster