D205 Support - Models#32575
Merged
Merged
Conversation
ferruzzi
requested review from
XD-DENG,
ashb,
dstandish,
kaxil and
uranusjr
as code owners
July 13, 2023 05:29
uranusjr
reviewed
Jul 13, 2023
Co-authored-by: Tzu-ping Chung <[email protected]>
Contributor
Author
|
@uranusjr - Could you have another look when you get time? |
uranusjr
reviewed
Jul 18, 2023
Comment on lines
3319
to
3322
| class DagOwnerAttributes(Base): | ||
| """Table defining different owner attributes. | ||
| """ | ||
| Table defining different owner attributes. | ||
|
|
||
| For example, a link for an owner that will be passed as a hyperlink to the | ||
| "DAGs" view. | ||
| For example, a link for an owner that will be passed as a hyperlink to the "DAGs" view. | ||
| """ |
Member
There was a problem hiding this comment.
What does this change? The previous string looks fine to me
Contributor
Author
There was a problem hiding this comment.
ruff didn't like the summary sentence being one the same line as the triple-quotes (old line 3319 becomes new line 3318L:3319) an I removed the line break on old line 3321 (old lines 3321:3322 becomes new line 3321) since the string fits on one line fine..
Contributor
Author
There was a problem hiding this comment.
without the awkward git diff display, this:
"""Table defining different owner attributes.
For example, a link for an owner that will be passed as a hyperlink to the
"DAGs" view.
"""
changes to this:
"""
Table defining different owner attributes.
For example, a link for an owner that will be passed as a hyperlink to the "DAGs" view.
"""
uranusjr
approved these changes
Jul 18, 2023
potiuk
approved these changes
Jul 19, 2023
ephraimbuddy
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10742
D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be a blank line before the rest of the docstring. Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
There are almost a thousand violations in the repo so we're going to have to take this in bites.
PLEASE NOTE
There should be zero changes to any functional logic or type hinting in this PR, only changes to docstrings and whitespace. If you see otherwise, please call it out.
Included in this chunk
All files in the
airflow/modelsmodule.To test
If you comment out this line and run pre-commit in main you will get 250 errors. After these changes, "only" 147 remain and no files in the
airflow/modelsfolder should be on the list. After uncommenting that line and rerunning pre-commits, there should be zero regressions.