Fix permissions on /blocked endpoint#32571
Merged
Merged
Conversation
This endpoint is used to update the UI with how many dagruns are running out of the max active dagruns per dag. It requires no elevated perms. This also fixes the test coverage on this endpoint.
jedcunningham
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
July 12, 2023 21:41
bbovenzi
approved these changes
Jul 13, 2023
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
I actually don't think we need any UI changes.
eladkal
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This endpoint is used to update the UI with how many dagruns are running out of the max active dagruns per dag. It requires no elevated perms.
This also fixes the test coverage on this endpoint.
This PR doesn't fix the UI side of this feature, but does fix the endpoint behavior.