Skip to content

Fix rendering of dagRunTimeout#32565

Merged
bbovenzi merged 2 commits into
apache:mainfrom
sanjurm16:fix-dagruntimeout-view
Jul 13, 2023
Merged

Fix rendering of dagRunTimeout#32565
bbovenzi merged 2 commits into
apache:mainfrom
sanjurm16:fix-dagruntimeout-view

Conversation

@sanjurm16

@sanjurm16 sanjurm16 commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

This resolves the below issue:
closes: #32442
The dag details page originally rendered the timedelta value as string. Causing the value of dagRunTImeout to be rendered as [object Object]. This change will handle the rendering of dagRunTimeout separately like scheduleInterval

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 12, 2023
@boring-cyborg

boring-cyborg Bot commented Jul 12, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title #32442 fixed rendering of dagruntimeout Fix rendering of dagRunTImeout Jul 12, 2023
tirkarthi
tirkarthi reviewed Jul 12, 2023
View reviewed changes
Comment thread airflow/www/static/js/dag/details/Dag.tsx Outdated
<Text>null</Text>
) : (
// for TimeDelta and RelativeDelta
<ViewScheduleInterval

@tirkarthi tirkarthi Jul 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViewScheduleInterval couples this component with dag's schedule interval. Maybe this could be refactored/renamed to ViewTimeDelta component to be used in schedule interval and dag run timeout to render timedelta values?

@sanjurm16 sanjurm16 Jul 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Let me take a look and make the change. Cheers.

@eladkal eladkal changed the title Fix rendering of dagRunTImeout Fix rendering of dagRunTimeout Jul 12, 2023
@sanjurm16
sanjurm16 requested a review from tirkarthi July 12, 2023 22:13
@bbovenzi bbovenzi added this to the Airflow 2.6.4 milestone Jul 13, 2023
@bbovenzi
bbovenzi merged commit f1fc6dc into apache:main Jul 13, 2023
@boring-cyborg

boring-cyborg Bot commented Jul 13, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jul 14, 2023
@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes
@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes
@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton
@ashb ashb Awaiting requested review from ashb
@tirkarthi tirkarthi Awaiting requested review from tirkarthi

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Milestone

Airflow 2.7.0

Development

Successfully merging this pull request may close these issues.

Dag run timeout with timedelta value is rendered as [object object] in UI

5 participants

@sanjurm16 @tirkarthi @bbovenzi @pierrejeambrun @eladkal