Strong-type single-state enum values#32537
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:core-operators
area:Scheduler
uranusjr
force-pushed
the
job-and-pod-state
branch
from
July 12, 2023 01:51
898194f to
c1eae2d
Compare
ephraimbuddy
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More State constant conversions. Also switch
State.finishedtoState.finished_dr_stateswhen used to compare against DagRunState.State.finishedis a set of TaskInstanceState so the comparison was not technically correct. Calls to save a state to Log are converted to use a string value instead of enum since Log data are free-form.