Display execution_date in graph view task instance tooltip.#32527
Merged
Conversation
tirkarthi
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
July 11, 2023 17:29
Contributor
Author
|
Testing in local with normal task and mapped task that displays "Run" value in the tooltip that corresponds to execution_date
|
hussein-awala
approved these changes
Jul 11, 2023
eladkal
reviewed
Jul 12, 2023
| "end_date": group_end_date, | ||
| "mapped_states": mapped_states, | ||
| "try_number": get_try_count(parent_instance._try_number, parent_instance.state), | ||
| "execution_date": parent_instance.execution_date, |
Contributor
There was a problem hiding this comment.
Shouldn't this be logical_date ?
Contributor
Author
There was a problem hiding this comment.
execution_date is the term used in the HTML template code where its referenced by graph view. Changing this to logical_date will require changes to frontend references and increase the scope of the PR.
eladkal
changed the title
eladkal
added
type:improvement
bbovenzi
approved these changes
Jul 25, 2023
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
Sure. Although, hopefully the whole graph view will be gone soon anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #32503
related: #32503
execution_date has become a proxy since commit 944dcfb. Explicitly fetch execution_date to display it in graph view.