Add timedelta support for applicable arguments of sensors#32515
Merged
Conversation
phanikumv
reviewed
Jul 11, 2023
Co-authored-by: Phani Kumar <[email protected]>
Member
|
Nice! Thanks @AlexisBRENON for taking the time to improve docs. I like the changes, I think though the title/description of the commit should be changed beceause it's more than doc change - it's also coertion and supporting timedelta. |
Contributor
Author
Yeah, maybe it should be two different PRs ? |
AlexisBRENON
changed the title
Member
Updating is fine :) |
potiuk
approved these changes
Jul 11, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #32512