Fix incorrect default on readonly property in our API#32510
Merged
potiuk merged 1 commit intoJul 11, 2023
Conversation
potiuk
requested review from
ashb,
bbovenzi,
ephraimbuddy,
pierrejeambrun and
ryanahamilton
as code owners
July 11, 2023 06:47
boring-cyborg
Bot
added
area:API
potiuk
changed the title
The new version of openapi-spec-validator (0.6.0) started to detect a bug in our API specification - readonly values cannot have defaults (by definition). This PR fixes the problem and also bumps the openapi-spec-validator to >= 0.6.0 to make sure it is used everywhere.
potiuk
force-pushed
the
fix-openapi-default-on-readonly-property
branch
from
July 11, 2023 06:49
6643c8d to
bcacf52
Compare
uranusjr
approved these changes
Jul 11, 2023
uranusjr
left a comment
uranusjr
left a comment
Member
There was a problem hiding this comment.
I don’t know what the issue this finds, but if the validator says so, so it is.
Member
Author
It makes no sense to have default on readOnly property. |
Member
Author
|
default -> what value should be set automatically when we call an API when we miss to set it. This property is only returned by the API, so it should always be present and needs to be set (so there will never be case that we will have to assume some defaults). |
hussein-awala
approved these changes
Jul 11, 2023
Member
Author
|
TIL: |
pierrejeambrun
approved these changes
Jul 11, 2023
Member
Author
|
Static checks passed, API tests passed. merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of openapi-spec-validator (0.6.0) started to detect a bug in our API specification - readonly values cannot have defaults (by definition).
This PR fixes the problem and also bumps the openapi-spec-validator to >= 0.6.0 to make sure it is used everywhere.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.