Bugfix, prevent force of unpause on trigger DAG#32456
Merged
bbovenzi merged 1 commit intoJul 13, 2023
Merged
Conversation
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
July 9, 2023 14:47
boring-cyborg
Bot
added
area:UI
jscheffl
added
kind:bug
bbovenzi
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache Airflow version
main (development) (not released)
What happened
This PR fixes a new bug introduced when finalizing AIP-50 and adjusting the trigger button behavior: Irrespective of the flag to unpause a DAG when using the Trigger UI, calling always un-pauses.
What you think should happen instead
Like advertised in the UI it should only be un-paused if the user selects so.
How to reproduce
Root cause: The un-pause flag was added into the trigger URL and irrespective of the form value the URL parameter overrules the form setting.
Operating System
Ubuntu 20.04 / Breeze Dev setup in Py 3.8 Container
Versions of Apache Airflow Providers
No specific setup, execution in Breeze from latest main
Deployment
Other
Deployment details
Development setup via
breeze start-airflow...Python 3.8
Postgres
Celery worker
Anything else
To improve visibility I added a flash() message as a reminder that unpause is needed. Removed the unpause URL parameter.
With this PR the behavior changes as follows:
This PR will very probably generate a merge conflict with PR #31301 which is still not merged :-( Will resolve it...
Are you willing to submit PR?
Code of Conduct