fix(api_connexion): handle the cases that webserver.expose_config is set to "non-sensitive-only" instead of boolean value#32261
Merged
potiuk merged 1 commit intoJun 29, 2023
Conversation
…set to non-sensitive-only instead of boolean value
potiuk
reviewed
Jun 29, 2023
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Nce. Seems it was only implemented for the "/configuration" endpoint.
potiuk
approved these changes
Jun 29, 2023
pankajkoti
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 1, 2023
potiuk
pushed a commit
that referenced
this pull request
Sep 1, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Sep 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the issue
In airflow/airflow/api_connexion/endpoints/config_endpoint.py,
conf.getboolean("webserver", "expose_config")only handle the boolean cases without handling "non-sensitive-only" which is a valid value according to docairflow/airflow/api_connexion/endpoints/config_endpoint.py
Line 79 in f2e2125
airflow/airflow/api_connexion/endpoints/config_endpoint.py
Line 108 in f2e2125
How to reproduce
files/airflow-breeze-config/variables.envbreeze --python 3.9 --backend sqlite start-airflowhttp://127.0.0.1:28080/api/v1/configandhttp://127.0.0.1:28080/api/v1/config/section/database/option/sql_alchemy_conn. both of them failWhat's changed
"non-sensitive-only" is handled in the code section mentioned in ## What's the issue. Sensitive data will be replace as
< hidden >like how it's implemented elsewhere^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.