D205 Support - Executors#32213
Merged
potiuk merged 1 commit intoJun 27, 2023
Merged
Conversation
ferruzzi
requested review from
XD-DENG,
ashb,
dstandish,
jedcunningham,
kaxil,
o-nikolas and
pierrejeambrun
as code owners
June 27, 2023 19:05
boring-cyborg
Bot
added
provider:cncf-kubernetes
potiuk
approved these changes
Jun 27, 2023
ephraimbuddy
added
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10742
D205 asserts that all docstrings must have a one-line summary ending in a period. If there is more than one sentence then there must be a blank line before the rest of the docstring. Meeting these requirements could be as simple as adding a newline, or might require some rephrasing.
There are almost a thousand violations in the repo so we're going to have to take this in bites.
Included in this chunk
All files related to Executors should be included in this batch.
To test
If you comment out this line and run pre-commit in main you will get around 937 errors. After these changes, "only" 926 remain and none of the files in
airflow/executorsor similar locations should be on the list. After uncommenting that line and rerunning pre-commits, there should be zero regressions.((...take one down, pass it around.... ))