Fix CLI commands when custom timetable is used#32118
Merged
Merged
Conversation
utkarsharma2
marked this pull request as draft
June 24, 2023 18:32
Contributor
Author
|
@uranusjr please check, I'm yet to add test cases for these changes. But I just wanted to confirm there are no side effects of these changes :) |
uranusjr
reviewed
Jun 28, 2023
Member
|
Other changes look correct to me. |
uranusjr
reviewed
Jun 30, 2023
uranusjr
approved these changes
Jun 30, 2023
uranusjr
force-pushed
the
FixCustomTimetable
branch
from
July 3, 2023 09:31
f076a05 to
58f7810
Compare
utkarsharma2
marked this pull request as ready for review
July 10, 2023 06:16
uranusjr
approved these changes
Jul 10, 2023
Member
|
Check failures are unrelated |
hussein-awala
approved these changes
Jul 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are CLI commands that are failing when passing a custom timetable. Following the example in the tutorial - https://airflow.apache.org/docs/apache-airflow/stable/howto/timetable.html and running the following commands will result in an error -
ValueError: Not a valid timetable: <workday.AfterWorkdayTimetable object at 0x7f50f9cd1700>The failure is due to missing
data_intervalwhen creating theDagRunobject. The PR aims at addingdata_intervalwhen we are creatingDagRun.data_intervalfor CLI commandscloses: Custom Timetable breaks a handful of CLI commands #31969