Open links in new tab that take us away from Airflow UI#32088
Merged
Conversation
pankajkoti
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
June 23, 2023 08:47
boring-cyborg
Bot
added
area:UI
I am observing that clicking on the "Click here" links take us away from Airflow UI to the docs domain and I need to press on back to get back to Airflow UI. Ideally, we could open these links in new tab and trying to do the same here with this commit using the targer="_blank" attribute for the anchor tags.
pankajkoti
force-pushed
the
open-links-in-new-tab
branch
from
June 23, 2023 08:47
0a42007 to
f4aa3dc
Compare
ephraimbuddy
approved these changes
Jun 23, 2023
utkarsharma2
approved these changes
Jun 23, 2023
potiuk
approved these changes
Jun 23, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
I am observing that clicking on the "Click here" links take us away from Airflow UI to the docs domain and I need to press on back to get back to Airflow UI. Ideally, we could open these links in new tab and trying to do the same here with this commit using the targer="_blank" attribute for the anchor tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am observing that clicking on the "Click here" links take us
away from Airflow UI to the docs domain and I need to press
on back button in the browser to get back to Airflow UI. Ideally,
we could open these links in new tab and trying to do the same
here with this commit using the
target="_blank"attribute forthe anchor tags.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.