Skip to content

Upgrade Flask-AppBuilder#32054

Merged
potiuk merged 1 commit into
apache:mainfrom
AVMusorin:upgrade-flask-appbuilder
Jul 8, 2023
Merged

Upgrade Flask-AppBuilder#32054
potiuk merged 1 commit into
apache:mainfrom
AVMusorin:upgrade-flask-appbuilder

Conversation

@AVMusorin

@AVMusorin AVMusorin commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

There are some helpful fixes in the new release of Flask-appbuilder

closes: #32002

@AVMusorin

AVMusorin commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

I'm going to check other changes in appbuilder since 4.3.1 and create a summary.

@AVMusorin
AVMusorin marked this pull request as draft June 21, 2023 16:35
@AVMusorin AVMusorin changed the title Draft: Upgrade Flask-AppBuilder Upgrade Flask-AppBuilder Jun 21, 2023
@eladkal eladkal added this to the Airlfow 2.6.3 milestone Jun 21, 2023
@eladkal
eladkal requested a review from potiuk June 22, 2023 15:38
@potiuk

potiuk commented Jun 23, 2023

Copy link
Copy Markdown
Member

I'm going to check other changes in appbuilder since 4.3.1 and create a summary.

Cool. I think the only thing that matters are changes that might need to be ported to airflow/www/fab_security: security_manager.py and sqla/* classes. they have corresponding files in FAB and we should just port the changes since the previous version (4.3.1)

@eladkal eladkal modified the milestones: Airlfow 2.6.3, Airlfow 2.6.4 Jul 6, 2023
@cvaliente

cvaliente commented Jul 8, 2023

Copy link
Copy Markdown
Contributor

@potiuk @AVMusorin
the only change in Flask-Appbuilder between 4.3.1 and 4.3.3 for the aforementioned files in airflow/www/fab_security is this commit: dpgaspar/Flask-AppBuilder@b2cec68
(fixing an old copy past mistake). It's a nice to have and easy to port over without worrying about anything breaking.

@potiuk
potiuk force-pushed the upgrade-flask-appbuilder branch from d6cf011 to 2498936 Compare July 8, 2023 10:23
@potiuk

potiuk commented Jul 8, 2023

Copy link
Copy Markdown
Member

dpgaspar/Flask-AppBuilder@b2cec68

Not affecting us. Thanks @cvaliente for checking. I mark the PR as "ready for review" and rebased it to latest main - and will merge it once it succeeds @AVMusorin - are you ok with that?

@potiuk
potiuk marked this pull request as ready for review July 8, 2023 10:24
@potiuk
potiuk merged commit 92497fa into apache:main Jul 8, 2023
@boring-cyborg

boring-cyborg Bot commented Jul 8, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Milestone

Airflow 2.7.0

Development

Successfully merging this pull request may close these issues.

log url breaks on login redirect

5 participants

@AVMusorin @potiuk @cvaliente @ephraimbuddy @eladkal