A couple of minor cleanups#31890
Merged
Merged
Conversation
This local import is not needed since Operator is already imported for typing at the top of the module, and we don't use it at runtime at all.
This makes the locking code more backend-compatible, and also more readable since the weird "unused" result is no longer in scope.
potiuk
approved these changes
Jun 23, 2023
potiuk
approved these changes
Jun 28, 2023
ephraimbuddy
added
type:improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator import is shadowing a global import and can be safely removed.
See #31791 for motivation behind the
with_for_updatechange. cc @tquazi @ephraimbuddy