Adapt Notifier for sla_miss_callback#31887
Merged
Merged
Conversation
utkarsharma2
requested review from
XD-DENG,
ashb,
ephraimbuddy,
jedcunningham and
kaxil
as code owners
June 14, 2023 05:50
boring-cyborg
Bot
added
the
area:Scheduler
utkarsharma2
changed the title
Contributor
Author
|
@ephraimbuddy Please review :) Also, I have tested this with SMTPNotifier with sla_miss_callback. |
utkarsharma2
marked this pull request as draft
June 14, 2023 05:56
utkarsharma2
marked this pull request as ready for review
June 14, 2023 06:33
ephraimbuddy
approved these changes
Jun 23, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
* Fix Notifier issue with sla_miss_callback * Add testcase to ensure the old pattern is working * Update document for existing notifier * Made notifier backward compatible with sla_miss_callback * Remove unwanted imports * Fix testcases * Fix static check * Fix PR comments * Removed unwanted code * Remove uneanted change * Updated var name * Remove kwargs * Fix documentation * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the notifier doesn't work with sla_miss_callback base notifier since the
__call__only expects a single parameterairflow/airflow/notifications/basenotifier.py
Line 82 in 7e7add0
But when the
sla_miss_callbackare called we pass multiple paramsairflow/airflow/dag_processing/processor.py
Line 533 in 7e7add0
Because of this, they are failing silently.