Skip to content

Add ExternalBranchPythonOperator#31843

Closed
MaliArbov wants to merge 1 commit into
apache:mainfrom
MaliArbov:external_branch_op
Closed

Add ExternalBranchPythonOperator#31843
MaliArbov wants to merge 1 commit into
apache:mainfrom
MaliArbov:external_branch_op

Conversation

@MaliArbov

Copy link
Copy Markdown

addd external branch python operator


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

addd external branch python operator

Co-Authored-By: hagitgit <[email protected]>
@boring-cyborg

boring-cyborg Bot commented Jun 11, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk

potiuk commented Jun 11, 2023

Copy link
Copy Markdown
Member

Good idea. But could you please add a unit test for the operator (similar that we have for the regular branch one - you can see how external Python operator unit tests are done and you can do in a similar).

The reason why we need tests is that when we cherry-pick such changes or make future changes, those tests help to keep our code to be free from regressions, there are cases and refactoring that might break things and such unit tests prevent it.

@MaliArbov

MaliArbov commented Jun 11, 2023 via email

Copy link
Copy Markdown
Author

@uranusjr uranusjr changed the title Update python.py Add ExternalBranchPythonOperator Jun 12, 2023
@hussein-awala
hussein-awala self-requested a review July 5, 2023 18:40
@hussein-awala hussein-awala added the type:new-feature Changelog: New Features label Jul 5, 2023
@hussein-awala hussein-awala added this to the Airflow 2.7.0 milestone Jul 5, 2023
@eladkal eladkal removed this from the Airflow 2.7.0 milestone Jul 24, 2023
@eladkal

eladkal commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

Resolved in #32787

@eladkal eladkal closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:new-feature Changelog: New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants