Add ExternalBranchPythonOperator#31843
Conversation
addd external branch python operator Co-Authored-By: hagitgit <[email protected]>
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Good idea. But could you please add a unit test for the operator (similar that we have for the regular branch one - you can see how external Python operator unit tests are done and you can do in a similar). The reason why we need tests is that when we cherry-pick such changes or make future changes, those tests help to keep our code to be free from regressions, there are cases and refactoring that might break things and such unit tests prevent it. |
|
Sure, I'll do it.
בתאריך יום א׳, 11 ביוני 2023 ב-12:12 מאת Jarek Potiuk <
***@***.***>:
… Good idea. But could you please add a unit test for the operator (similar
that we have for the regular branch one - you can see how external Python
operator unit tests are done and you can do in a similar).
The reason why we need tests is that when we cherry-pick such changes or
make future changes, those tests help to keep our code to be free from
regressions, there are cases and refactoring that *might* break things
and such unit tests prevent it.
—
Reply to this email directly, view it on GitHub
<#31843 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7L5GHCS5J3OODCD36KEG3DXKWDWXANCNFSM6AAAAAAZCGASRU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Resolved in #32787 |
addd external branch python operator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.