Skip to content

Remove unused query and codes in dag.py module#31791

Closed
ephraimbuddy wants to merge 1 commit into
apache:mainfrom
astronomer:remove-unused-query
Closed

Remove unused query and codes in dag.py module#31791
ephraimbuddy wants to merge 1 commit into
apache:mainfrom
astronomer:remove-unused-query

Conversation

@ephraimbuddy

Copy link
Copy Markdown
Contributor

I don't think this query is used anywhere. Can't find the usage. Raising a PR to discuss it

I don't think this query is used anywhere. Can't find the usage.
Raising a PR to discuss it
@ephraimbuddy

Copy link
Copy Markdown
Contributor Author

@tquazi , this seems to come from your change in #30478. Was the query not used, or am I missing something?

@tquazi

tquazi commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

@ephraimbuddy The query is used to lock the related dag runs to prevent from possible dead lock.

@uranusjr

uranusjr commented Jun 9, 2023

Copy link
Copy Markdown
Member

Judging from the variable name, there’s probably supposed to be a with_row_lock somewhere. Maybe it got removed accidentally at some point?

@uranusjr

uranusjr commented Jun 9, 2023

Copy link
Copy Markdown
Member

Ah I missed the with_for_update call, so yeah that should be changed to use with_row_locks to make the intention clearer (and more portable across databases).

@ephraimbuddy

Copy link
Copy Markdown
Contributor Author

Ah I missed the with_for_update call, so yeah that should be changed to use with_row_locks to make the intention clearer (and more portable across databases).

Yeah. Didn't see that too

@ephraimbuddy
ephraimbuddy deleted the remove-unused-query branch June 9, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants