Better error message when serializing callable without name#31778
Merged
potiuk merged 1 commit intoJun 7, 2023
Merged
Conversation
When Callable without `__name__` got serialized, the error message was pretty cryptic: `AttributeError: __name__. Did you mean: '__ne__'?` without printing what the failing type is. This PR adds a more meaningful message Related to apache#31753, apache#31499
2 tasks
potiuk
force-pushed
the
better-error-when-serializing-callable-with-no-name-attribute
branch
from
June 7, 2023 18:34
fdfadb8 to
353719d
Compare
potiuk
deleted the
better-error-when-serializing-callable-with-no-name-attribute
branch
June 7, 2023 19:25
eladkal
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Callable without
__name__got serialized, the error message was pretty cryptic:AttributeError: __name__. Did you mean: '__ne__'?without printing what the failing type is.This PR adds a more meaningful message
Related to #31753, #31499
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.