Migration of all DAG details to existing grid view dag details panel#31690
Conversation
boring-cyborg
Bot
added
area:UI
Adaverse
changed the title
There was a problem hiding this comment.
A few small changes to maintain UX compatibility for now.
A rebase is needed
Looks like we're not parsing objects correctly:
Final big piece of feedback, (which can be a secondary PR). It's a very long list of data, I think we should play with other ways to show this data. At least two columns on wide screens. Or maybe a dashboard style with various cards?
| <Text>Total {val}</Text> | ||
| <SimpleStatus state={val as TaskState} /> | ||
| <LinkButton | ||
| href={getRedirectUri(val)} |
There was a problem hiding this comment.
We probably want this to be just a link, not a button
There was a problem hiding this comment.
Made it a Link!
Shall we direct the users clikcing the Link in a new TAB?
There was a problem hiding this comment.
I think the same tab is fine, new tab is mainly for external links. Wanna make it blue and/or underlined to let users still know they can click it?
| wrapped=conf.getboolean("webserver", "default_wrap"), | ||
| ) | ||
|
|
||
| @expose("/dag_details") |
There was a problem hiding this comment.
We're missing the redirect for this URL and the legacy one.
There was a problem hiding this comment.
I have reverted the changes! Not much idea on the legacy side. Would need your help with the removal of irrelevant parts
| <span class="material-icons" aria-hidden="true">code</span> | ||
| Code | ||
| </a> | ||
| <a href="{{ url_for('Airflow.dag_details', dag_id=dag.dag_id) }}" class="dags-table-more__link"> |
There was a problem hiding this comment.
Let's leave this and just change the URL
There was a problem hiding this comment.
U mean to change the url to {{ url_for('Airflow.grid', dag_id=dag.dag_id, num_runs=num_runs) }} i.e the dag detials in Grid view?
There was a problem hiding this comment.
But there's already a Grid option here that directs to the above URL.
Lets keep the dag_details.html and all the button leading to it intact and remove them all at once?
| <li><a href="{{ url_for('Airflow.gantt', dag_id=dag.dag_id, root=root, num_runs=num_runs_arg, base_date=base_date_arg, execution_date=execution_date_arg) }}"> | ||
| <span class="material-icons" aria-hidden="true">vertical_distribute</span> | ||
| Gantt</a></li> | ||
| <li><a href="{{ url_for('Airflow.dag_details', dag_id=dag.dag_id) }}"> |
There was a problem hiding this comment.
For now, let's leave this and just change the URL. I think it will be best to switch all of these buttons over at once.
There was a problem hiding this comment.
Assuming here also you are referring to change the URL to {{ url_for('Airflow.grid', dag_id=dag.dag_id, num_runs=num_runs) }} will create redundant buttons and will look like below
I think it's best removed. We can keep it in dags.html anyways. Let me know if u meant something else by any chance.
There was a problem hiding this comment.
Yeah, we can do this in a later PR.
Rebased |
Since we were combining the So have transferred the combining logic to |
Indeed totally agree. Let's take it up after this. The idea is to view all data in one screen (without any scroll). |
Co-authored-by: Brent Bovenzi <[email protected]>
Co-authored-by: Brent Bovenzi <[email protected]>
3 participants
Addresses few sub tasks: #29859
Tasks
/dags/{dag_id}/detailsto the dag details panel in grid view from the API endpointsdags/{dag_id}anddag/{dag_id}/details(when a user doesn't have a task or run selected).Below are screenshots -
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.