Improve the views module a bit#31661
Merged
Merged
Conversation
uranusjr
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
June 1, 2023 05:15
uranusjr
commented
Jun 1, 2023
Member
Author
There was a problem hiding this comment.
This is removed outright since the function is not used at all in the entire code base.
jedcunningham
approved these changes
Jun 1, 2023
Member
|
needs test fixing, I am afraid |
This mostly involves making more SQL queries lazy by removing all(), and some collection-building loops into comprehensions. In only a few cases I made deeper changes such as rewriting filtering done in Python to SQL.
Co-authored-by: Jed Cunningham <[email protected]>
No need to import markupsafe twice, once qualified and once not.
Member
Author
|
Hmm static check failure seems unrelated (unchanged files, also failed on main) so I’ll fix them in another PR. |
eladkal
added
the
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly involves making more SQL queries lazy by removing all(), and some collection-building loops into comprehensions. In only a few cases I made deeper changes such as rewriting filtering done in Python to SQL.