Fix for "Filter dags by tag" flickering on initial load of dags.html#31578
Merged
Conversation
Adaverse
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
May 27, 2023 13:03
boring-cyborg
Bot
added
area:UI
Contributor
|
Actually, I think I messed up the nav bar flex box css. 
|
Contributor
Author
The rest should center as the filter height increases right? |
Contributor
Author
|
Is it fine @bbovenzi ?
|
Contributor
Much better! |
Contributor
Author
bbovenzi
approved these changes
Jun 2, 2023
Contributor
|
moving to 2.7.0 this depends on PRs that are part of 2.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isuue -
Flicker.issue.mp4
The below the flicker snapshot -
Its probably because HTML loads faster than JS.
Fix -
Added
display: none;to the div causing the issue. Hence it will be hidden unless JS loads, and after it, it becomes visible without any flicker.Flicker.fix.mp4
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.