Skip to content

Fixing small typo in python.py#31474

Merged
jedcunningham merged 1 commit into
apache:mainfrom
MMak1599:Fixing-small-typo
May 24, 2023
Merged

Fixing small typo in python.py#31474
jedcunningham merged 1 commit into
apache:mainfrom
MMak1599:Fixing-small-typo

Conversation

@MMak1599

Copy link
Copy Markdown
Contributor

Noticed a small typo in airflow/operators/python.py: 'for a other downstream tasks'.
This commit corrects this typo from 'for a other' to 'for all other'.

^ Add meaningful description above**

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg

boring-cyborg Bot commented May 23, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@dbell-scottlogic dbell-scottlogic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread airflow/operators/python.py
@hussein-awala hussein-awala added the type:doc-only Changelog: Doc Only label May 24, 2023
@jedcunningham

Copy link
Copy Markdown
Member

Merging. (Failed static check is unrelated)

@jedcunningham
jedcunningham merged commit e4f5cb0 into apache:main May 24, 2023
@boring-cyborg

boring-cyborg Bot commented May 24, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:doc-only Changelog: Doc Only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants