Give more time for trigger logs to propagate in tests#31470
Merged
potiuk merged 1 commit intoapache:mainfrom May 23, 2023
Merged
Give more time for trigger logs to propagate in tests#31470potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
After apache#29482 triggerer logs are not printed directly to the stdout, but they are queued in memory and written by a separate thread. This causes a slight flakiness in case of CI tests for test_trigger_job - especially on MSSQL. This simple workaround should give more time to the logs to propgate during the test
Member
Author
|
Example flaky test: |
hussein-awala
approved these changes
May 23, 2023
Member
hussein-awala
left a comment
There was a problem hiding this comment.
Is it enough to ensure the success of the test?
pankajkoti
approved these changes
May 23, 2023
Member
Author
It's magic number. In case you have REALLY busy system when the writing thread gets starved, I guess it might still happen. We could likely implement some "complete" solution that would not have to wait for it, but it would take quite some time to figure out how to tap into the in-memory queue of the writing thread. Adding 0.5 s will of course increase time of running for the tests, and it will also likely decrease the probability of such event to a REALLY LOW one. And it's one line.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #29482 triggerer logs are not printed directly to the stdout, but they are queued in memory and written by a separate thread. This causes a slight flakiness in case of CI tests for test_trigger_job - especially on MSSQL.
This simple workaround should give more time to the logs to propgate during the test
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.