Allow skipped task state task_instance_schema.py#31421
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
Allowing all the TI states is not a good idea, where this can lead to unexpected result.
IMO, the task could be stucked if we change its state manually to deferred, removed, shutdown, ...
You can just add skipped as accepted value in these methods. Don't forget to add a unit test for your change
|
Fair enough, I'm just a sucker for generic solutions, but you're right, we probably wouldn't want states like those to be set manually. |
hussein-awala
left a comment
There was a problem hiding this comment.
As a new contributor, you should read and follow this doc.
I'll merge the PR once the CI is passed.
|
@potiuk, do you have any idea why some of the CI checks fail without being executed? Is it related to the changes made yesterday, or is it just a temporary problem? |
|
Likely intermittent. Looks like temporary Github Issue. Easiest is to rebase it or close/reopen such PR. |
|
It still has the same problem after rebasing and closing/reopening it. |
|
@potiuk I think it's indeed related, the job has |
|
@JoranDox The PR is almost ready, can you fix the CI so we can merge it ? |
Apologies, I thought the CI had issues unrelated to my code and was kind of ignoring the mailthread, thanks for pinging me! I forgot to import TaskInstanceState, but that should be all I think. |
|
No idea what those sql failing tests have to do with my PR.. e.g. the fact that these two strings are not the same doesn't seem quite relevant to allowing the "skipped" state? E - http://localhost:8080/ javascript:alert(1) |
|
Make sure to rebase your branch, you are 25 commits behind, there's been work on those, and fix might already be in main. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |

closes: #31420
this PR is mostly to accompany my issue #31420