Add support for configuring custom alembic file#31415
Merged
Merged
Conversation
Contributor
Author
|
@hussein-awala can you take a look at this PR when you have some time? |
uranusjr
reviewed
May 22, 2023
uranusjr
approved these changes
May 22, 2023
Co-authored-by: Hussein Awala <[email protected]>
hussein-awala
approved these changes
May 22, 2023
hussein-awala
left a comment
hussein-awala
left a comment
Member
There was a problem hiding this comment.
You need to run pre-commit hooks after the last change, to update the default_airflow.cfg file, otherwise static checks will fail
Contributor
Author
|
Let me pull the changes locally and push it once I run the hooks |
ephraimbuddy
approved these changes
May 22, 2023
Contributor
Author
|
@hussein-awala @ephraimbuddy I was able to fix the CI here. We can merge this one as we have a clean build here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support to provide a custom alembic file with logging support. Motivation: #30563 (review)
Closes #30562
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.