Fix KubernetesPodTrigger waiting strategy
#31348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
2 tasks
potiuk
approved these changes
Jun 11, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM but I would prefer someone else who knows more about async triggers and k8s to approve it.
Member
Author
|
@jedcunningham could you review this PR? |
vincbeck
approved these changes
Jun 29, 2023
69 tasks
hussein-awala
added a commit
to hussein-awala/airflow
that referenced
this pull request
Jul 9, 2023
This reverts commit 8f5de83. Signed-off-by: Hussein Awala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31335
This PR waits for the pod to reach a terminated state before triggering a success event and resuming the task.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.