Skip to content

Wrap grid view task actions and restore default clear params#31232

Merged
bbovenzi merged 8 commits into
apache:mainfrom
Adaverse:Adaverse-patch-1
May 12, 2023
Merged

Wrap grid view task actions and restore default clear params#31232
bbovenzi merged 8 commits into
apache:mainfrom
Adaverse:Adaverse-patch-1

Conversation

@Adaverse

Copy link
Copy Markdown
Contributor

Closes - #31186

The issue is that the Clear task button goes out of the screen when we have a very long task or dag name.

issue.mp4

Below is the resolved state -

resolved.mp4

Also changed the default selected option for ClearInstance modal to Downstream and Recursive. Also, modified the resetModal function to reset the modal state back to the previous state.

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels May 11, 2023

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@bbovenzi bbovenzi added this to the Airflow 2.6.2 milestone May 12, 2023
@bbovenzi
bbovenzi merged commit 03b04a3 into apache:main May 12, 2023
@bbovenzi bbovenzi changed the title Resolving problems with redesigned grid veiw Wrap grid view task actions and restore default clear params May 12, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jun 8, 2023
@eladkal

eladkal commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Moving to milestone 2.7.0 as this PR is depended on #30478

@eladkal eladkal modified the milestones: Airflow 2.6.2, Airflow 2.7.0 Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants