Skip to content

TriggerDagRunOperator: Add wait_for_completion to template_fields#31122

Merged
eladkal merged 6 commits into
apache:mainfrom
rogue-gamer-ryt:feature/dynamic_wait_for_completion
Jun 25, 2023
Merged

TriggerDagRunOperator: Add wait_for_completion to template_fields#31122
eladkal merged 6 commits into
apache:mainfrom
rogue-gamer-ryt:feature/dynamic_wait_for_completion

Conversation

@rogue-gamer-ryt

Copy link
Copy Markdown
Contributor

Added wait_for_completion to template_fields to make it configurable

Adding wait_for_completion to template_fields would now enable setting its value dynamically via dag_run.conf
related: #31117

@boring-cyborg

boring-cyborg Bot commented May 7, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk

potiuk commented May 13, 2023

Copy link
Copy Markdown
Member

Static checks needs to be fixed (pre-commit install and git commit --amend with rebase should fix those automatically).

@eladkal eladkal added this to the Airflow 2.6.2 milestone May 20, 2023
@eladkal eladkal added the type:improvement Changelog: Improvements label May 20, 2023
@rogue-gamer-ryt

Copy link
Copy Markdown
Contributor Author

@eladkal, can this PR be merged?

@eladkal eladkal modified the milestones: Airflow 2.6.2, Airflow 2.7.0 Jun 8, 2023
@eladkal eladkal changed the title added wait_for_completion to template_fields to make it configurable TriggerDagRunOperator: Add wait_for_completion to template_fields Jun 24, 2023
@eladkal
eladkal merged commit 2c645d5 into apache:main Jun 25, 2023
@boring-cyborg

boring-cyborg Bot commented Jun 25, 2023

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 27, 2023
…s` (apache#31122)

* added wait_for_completion to template_fields
---------

Co-authored-by: eladkal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants