Fix webserver crash when calling get /config#31057
Merged
Merged
Conversation
pankajastro
requested review from
ashb,
bbovenzi,
ephraimbuddy and
ryanahamilton
as code owners
May 4, 2023 12:25
boring-cyborg
Bot
added
area:API
currently, if the section is not found we raise AirflowNotFoundException and that does not handle returning response gracefully and the web server crash I think the right expectation to raise here should be NotFound
pankajastro
force-pushed
the
fix_webserver_crash
branch
from
May 4, 2023 12:26
e8bb51a to
56dbaeb
Compare
pierrejeambrun
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, if the section is not found we raise AirflowNotFoundException
and that does not handle returning response gracefully and the web server crash
I think the right expectation to raise here should be NotFound
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.