Skip to content

Add section query param in get config rest API#30936

Merged
dstandish merged 5 commits into
apache:mainfrom
astronomer:get_section_config
Apr 28, 2023
Merged

Add section query param in get config rest API#30936
dstandish merged 5 commits into
apache:mainfrom
astronomer:get_section_config

Conversation

@pankajastro

Copy link
Copy Markdown
Member

currently, endpoint GET /config always returns all config
It would be nice if we can expose a way to get a single section of the config
using rest API.
This PR add a query param section in the existing GET /config API
if the section query param given by a user does not exist then the API throws an error
if a section exists and return that section only
and if the user call API without section param then return all config.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Apr 28, 2023
@pankajastro
pankajastro marked this pull request as ready for review April 28, 2023 06:57
Comment thread tests/api_connexion/endpoints/test_config_endpoint.py

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstandish
dstandish merged commit 783aa9c into apache:main Apr 28, 2023
@dstandish
dstandish deleted the get_section_config branch April 28, 2023 17:24
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.0 milestone May 8, 2023
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants