Improve DAG ORM cleanup code#30614
Merged
Merged
Conversation
uranusjr
requested review from
XD-DENG,
ashb,
ephraimbuddy,
jedcunningham and
kaxil
as code owners
April 13, 2023 04:47
boring-cyborg
Bot
added
area:Scheduler
Member
|
Sounds legit. I think there was a transient error on that one though. |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
Bot
added
the
stale
uranusjr
force-pushed
the
dag-orm-refresh-refactor
branch
from
June 21, 2023 05:18
dc113d2 to
553ca26
Compare
uranusjr
removed
the
stale
I identified when reviewing apache#30608 that the _refresh_dag_dir() function can use some cleanup, mainly to use a set instead of list to speed up lookup. To maintain backward comaptibility in typ hints, the called functions are changed to use the Collection generic instead of the very narrow list type. This somehow triggers a bunch of (legistimate) Mypy errors not emitted previously, mostly around mixing the os.PathLike generic and the pathlib.Path concrete type. I fixed those as well.
uranusjr
force-pushed
the
dag-orm-refresh-refactor
branch
from
June 21, 2023 07:20
553ca26 to
4e5bf97
Compare
jedcunningham
approved these changes
Jun 22, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I identified when reviewing #30608 that the _refresh_dag_dir() function can use some cleanup, mainly to use a set instead of list to speed up lookup. To maintain backward comaptibility in type hints, the called functions are changed to use the Collection generic instead of the very narrow list type.
This somehow triggers a bunch of (legistimate) Mypy errors not emitted previously, mostly around mixing the os.PathLike generic and the pathlib.Path concrete type. I fixed those as well.