Deactivate DAGs deleted from within zipfiles#30608
Merged
Merged
Conversation
luos-fc
requested review from
XD-DENG,
ashb,
ephraimbuddy,
jedcunningham and
kaxil
as code owners
April 12, 2023 18:27
boring-cyborg
Bot
added
the
area:Scheduler
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
luos-fc
force-pushed
the
fix-zipped-dag-deactivation
branch
from
April 12, 2023 18:28
61eeb9b to
5262b6d
Compare
luos-fc
force-pushed
the
fix-zipped-dag-deactivation
branch
from
April 12, 2023 18:55
5262b6d to
97c3942
Compare
ephraimbuddy
approved these changes
Apr 12, 2023
uranusjr
approved these changes
Apr 13, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
uranusjr
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 13, 2023
I identified when reviewing apache#30608 that the _refresh_dag_dir() function can use some cleanup, mainly to use a set instead of list to speed up lookup. To maintain backward comaptibility in typ hints, the called functions are changed to use the Collection generic instead of the very narrow list type. This somehow triggers a bunch of (legistimate) Mypy errors not emitted previously, mostly around mixing the os.PathLike generic and the pathlib.Path concrete type. I fixed those as well.
uranusjr
added a commit
to astronomer/airflow
that referenced
this pull request
Jun 21, 2023
I identified when reviewing apache#30608 that the _refresh_dag_dir() function can use some cleanup, mainly to use a set instead of list to speed up lookup. To maintain backward comaptibility in typ hints, the called functions are changed to use the Collection generic instead of the very narrow list type. This somehow triggers a bunch of (legistimate) Mypy errors not emitted previously, mostly around mixing the os.PathLike generic and the pathlib.Path concrete type. I fixed those as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the logic for deactivating deleted DAGs to check if the DAG file within a zip has been deleted, not just checking if the zip has been deleted.
A test has been added which fails against main, but succeeds with the new changes.
Closes #30600