Add tests to PythonOperator#30583
Conversation
potiuk
added
the
full tests needed
|
Applied "full tests needed" label/closed and reopened to build for all python versions for better visibility. FYI - you can convert it to Draft to make sure it is not going to be merged accidentally @vincbeck |
|
(I just converted it to Draft) |
Good call! Thanks for doing it |
|
mmm tests pass. So what did we miss in the first attempt? |
VERY GOOD QUESTION. I have no idea :) . I could not reproduce it back then either, but reverting it helped ... One thing that came to my mind is that it was only happening on "self-hosted runners" of ours (this is the only difference of the public PR vs. I will push the code myself in a separate draft PR to verify that hypothesis |
|
Draft PR of mine running here #30588 |
ecf57b6 to
1dfbed6
Compare
7b8093d to
4eef359
Compare
Previously deserialization error thrown a pretty mysterious ValueError in case for example there was a Python version mismatch - the python object serialized in one version of Python produced "version error" messsage. This change turns such ValueError in specific Deserilization error, with better message explaining possible reason, but also without loosing the cause. Co-authored-by: Shahar Epstein <[email protected]> Co-authored-by: Vincent <[email protected]>
4eef359 to
bf3d01a
Compare
4 participants
Reopening #30362 after being reverted. I did not make any modifications from #30362 so please do not merge until be sure it wont cause
mainto fail again.Opening this one to see if tests are passing
@potiuk
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.