Skip to content

Change alembic logging level to WARN#30563

Closed
geekykayaker wants to merge 1 commit into
apache:mainfrom
geekykayaker:patch-1
Closed

Change alembic logging level to WARN#30563
geekykayaker wants to merge 1 commit into
apache:mainfrom
geekykayaker:patch-1

Conversation

@geekykayaker

@geekykayaker geekykayaker commented Apr 10, 2023

Copy link
Copy Markdown

closes: #30562


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg

boring-cyborg Bot commented Apr 10, 2023

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@geekykayaker geekykayaker mentioned this pull request Apr 10, 2023
2 tasks
@uranusjr

Copy link
Copy Markdown
Member

Do not use WARN. Use WARNING instead. If we agree to do this.

@hussein-awala hussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the alembic logging configuration are loaded from this file without any possibility to update them:

config = Config(os.path.join(package_dir, "alembic.ini"))

I think it might be a good feature if we add a new Airflow configuration to provide a custom ini file for alembic, then you can update it as you like in your Airflow server. WDYT?

@geekykayaker

Copy link
Copy Markdown
Author

Yeah, I think that's a more complete solution, and would certainly resolve this for me.

@saulbein

Copy link
Copy Markdown

What about setting up logging_config_class before running alembic commands and not touching logs with alembic at all? That way we could use the existing logging override mechanism to do what we want with the alembic logs.

@potiuk

potiuk commented Apr 22, 2023

Copy link
Copy Markdown
Member

Currently the alembic logging configuration are loaded from this file without any possibility to update them:

config = Config(os.path.join(package_dir, "alembic.ini"))

I think it might be a good feature if we add a new Airflow configuration to provide a custom ini file for alembic, then you can update it as you like in your Airflow server. WDYT?

Agree with @hussein-awala - being able to specify alembic.ini would be much better.

@github-actions

github-actions Bot commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 7, 2023
@hussein-awala

Copy link
Copy Markdown
Member

the issue was closed by #31415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alembic Logging

5 participants